Anim not able to modify user except "place" #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… except "place" in user modal
|
Pour le coup ça s'était un fonctionnement attendu car ce n'est pas le rôle pour moi de l'anim de modifier le nom, prénom ou email d'une personne. Pour moi, même si c'est peu probable, on est pas à l'abri d'un détournement de compte (changement nom, prénom, email et mdp) pour récup le contrôle d'un compte qui a payé. Bon après voilà c'est juste mon petit avis sur la question et sur la manière dont on a codé ça avec Teddy l'an dernier donc faites comme vous voulez |
|
Bah justement je viens d'enlever le fait qu'ils pouvaient 😅 |
|
Ah yes j'ai mal lu le code 😂 |
DevNono
approved these changes
Oct 11, 2024
Suboyyy
added a commit
that referenced
this pull request
Oct 13, 2024
* Custom badge commission input (#402) * commission : input, add permission field * orga permisison is orgaprice * fix: permission can know be invite + add ' ' value * fix: permission as BadgePermission --------- Co-authored-by: Antoine D <[email protected]> * security: disable possibility for non-admin users from editing fields except "place" in user modal (#404) * feat: trailer added (#405) Co-authored-by: Antoine D <[email protected]> --------- Co-authored-by: Antoine D <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anim not able to modify user except "place"